Attention is currently required from: Simon Buhrow, Thomas Heijligen, Aarya, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67535 )
Change subject: [WIP] Unit tests for erase function selection algo ......................................................................
Patch Set 3:
(7 comments)
Patchset:
PS3: not meant as a review, just some tips.
File tests/erase_func_algo.c:
https://review.coreboot.org/c/flashrom/+/67535/comment/2bf6f1f0_65467840 PS3, Line 238: void **state `g_state` should probably be passed in here.
https://review.coreboot.org/c/flashrom/+/67535/comment/90d50d45_9a2de72c PS3, Line 276: void **state ditto.
https://review.coreboot.org/c/flashrom/+/67535/comment/f9384e14_30c9f407 PS3, Line 282: uint8_t *const newcontents = malloc(MIN_BUF_SIZE); `uint8_t newcontents[MIN_BUF_SIZE];`
https://review.coreboot.org/c/flashrom/+/67535/comment/95734623_2aab8c8a PS3, Line 291: n `&n`
https://review.coreboot.org/c/flashrom/+/67535/comment/a5d29860_6e521ae4 PS3, Line 294: n `&n`
https://review.coreboot.org/c/flashrom/+/67535/comment/a58b3d39_7238589c PS3, Line 313: : free(newcontents); drops lines 313&&314.