Attention is currently required from: Simon Buhrow, Thomas Heijligen, Aarya, Anastasia Klimchuk.

View Change

7 comments:

• Patchset:

  • Patch Set #3:

    not meant as a review, just some tips.

• File tests/erase_func_algo.c:

  • Patch Set #3, Line 238: void **state

    `g_state` should probably be passed in here.

  • Patch Set #3, Line 276: void **state

    ditto.

  • Patch Set #3, Line 282: uint8_t *const newcontents = malloc(MIN_BUF_SIZE);

    `uint8_t newcontents[MIN_BUF_SIZE];`

  • Patch Set #3, Line 291: n

    `&n`

  • Patch Set #3, Line 294: n

    `&n`

  • Patch Set #3, Line 313:

    
    	free(newcontents);
    

    drops lines 313&&314.

To view, visit change 67535. To unsubscribe, or for help writing mail filters, visit settings.