Change in flashrom[master]: libflashrom: Allow getting the progress_state from the flashctx

[Nico Huber (Code Review)]

Attention is currently required from: Felix Singer, Richard Hughes.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64663 )

Change subject: libflashrom: Allow getting the progress_state from the flashctx
......................................................................


Patch Set 2:

(3 comments)

Patchset:

PS2: 
Felix, thanks for the invitation. Not sure what to do, though, as I don't
understand the API.

Richard, have you tested if the current implementation works? I'm a bit
confused about when update_progress() should get called. Does it do any-
thing on a modern Intel system at all?

There are odd paths like spi_chip_read() calls into the master, which may
call spi_read_chunked() which calls update_progress(). But spi_chip_read()
calls it as well? I wonder what was the reason to do it at the chip and
programmer levels.


File include/libflashrom.h:

https://review.coreboot.org/c/flashrom/+/64663/comment/d62c7ca9_49c76e5b 
PS2, Line 85: typedef void(flashrom_progress_callback)(struct flashrom_flashctx *flashctx);
Why doesn't it get the progress passed directly?


https://review.coreboot.org/c/flashrom/+/64663/comment/f1838035_d834604b 
PS2, Line 95:  * callback.
The library user passes the progress state?



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/64663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010
Gerrit-Change-Number: 64663
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Hughes <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Daniel Campello <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Felix Singer <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Sean Rhodes <[e-mail]>
Gerrit-Reviewer: Thomas Heijligen <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Felix Singer <[e-mail]>
Gerrit-Attention: Richard Hughes <[e-mail]>
Gerrit-Comment-Date: Fri, 27 May 2022 12:26:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment