Attention is currently required from: Felix Singer, Richard Hughes.

View Change

3 comments:

• Patchset:

  • Patch Set #2:

    Felix, thanks for the invitation. Not sure what to do, though, as I don't
    understand the API.

    Richard, have you tested if the current implementation works? I'm a bit
    confused about when update_progress() should get called. Does it do any-
    thing on a modern Intel system at all?

    There are odd paths like spi_chip_read() calls into the master, which may
    call spi_read_chunked() which calls update_progress(). But spi_chip_read()
    calls it as well? I wonder what was the reason to do it at the chip and
    programmer levels.

• File include/libflashrom.h:

  • Patch Set #2, Line 85: typedef void(flashrom_progress_callback)(struct flashrom_flashctx *flashctx);

    Why doesn't it get the progress passed directly?

  • Patch Set #2, Line 95: * callback.

    The library user passes the progress state?

To view, visit change 64663. To unsubscribe, or for help writing mail filters, visit settings.