Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/25683 )
Change subject: Add support for National Instruments USB-845x devices ......................................................................
Patch Set 28:
(3 comments)
Didn't want to bikeshed this further ._. but then found a real issue: the strcmp() vs. strstr().
https://review.coreboot.org/c/flashrom/+/25683/28/flashrom.8.tmpl File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/25683/28/flashrom.8.tmpl@1141 PS28, Line 1141: the second "the" in the first sentence seems spurious
https://review.coreboot.org/c/flashrom/+/25683/28/flashrom.8.tmpl@1141 PS28, Line 1141: In the case if the none of the programmer's supported IO voltage is within the supported voltage range of the detected flash chip the flashrom will abort the operation (to prevent damaging the flash chip). You can override this behaviour by passing "yes" to the also, a spurious space at the end of the line, and the line should be broken (somewhere <80 chars)
https://review.coreboot.org/c/flashrom/+/25683/26/ni845x_spi.c File ni845x_spi.c:
https://review.coreboot.org/c/flashrom/+/25683/26/ni845x_spi.c@440 PS26, Line 440: strlen(ignore_io_voltage_limits_str) == 3 : && strstr("yes", ignore_io_voltage_limits_str) == 0
Done
I meant strcmp(), not strstr().
-
Nico Huber (Code Review)