Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57269 )
Change subject: tests: Add NOT_ZERO and NOT_NULL macros to the header file ......................................................................
Patch Set 1:
(2 comments)
File tests/io_mock.h:
https://review.coreboot.org/c/flashrom/+/57269/comment/3baf0341_0e165af4 PS1, Line 37: NOT
NONZERO ?
Would you agree on NON_ZERO (with underscore)? I think it's a bit more readable.
https://review.coreboot.org/c/flashrom/+/57269/comment/863054d9_246ca3d4 PS1, Line 38: NOT_NULL ((void *)NOT_ZERO)
I wonder if this should be a function ptr address so that you can set a break point on the address e […]
Is it ok for this stub function to be in this header? And also, the same question as previous comment, is it ok to have not_null() and non_zero() with underscores?
-
Anastasia Klimchuk (Code Review)