Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

2 comments:

• File tests/io_mock.h:

  • Patch Set #1, Line 37: NOT

    NONZERO ?

    Would you agree on NON_ZERO (with underscore)? I think it's a bit more readable.

  • Patch Set #1, Line 38: NOT_NULL ((void *)NOT_ZERO)

    I wonder if this should be a function ptr address so that you can set a break point on the address e […]

    Is it ok for this stub function to be in this header?
    And also, the same question as previous comment, is it ok to have not_null() and non_zero() with underscores?

To view, visit change 57269. To unsubscribe, or for help writing mail filters, visit settings.