Attention is currently required from: Evan Benn.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67472 )
Change subject: flashrom_tester: Fix cargo check and clippy warnings ......................................................................
Patch Set 2:
(3 comments)
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/67472/comment/6e57f1bd_b1b1b2b9 PS2, Line 89: return This can be converted to drop the `return` too?
File util/flashrom_tester/src/tests.rs:
https://review.coreboot.org/c/flashrom/+/67472/comment/b80266a5_997f1eb0 PS2, Line 135: let mut filter_names: Option<HashSet<String>> = if let Some(names) = test_names { I think this version is easier to understand, but if you prefer the newer version then go ahead.
https://review.coreboot.org/c/flashrom/+/67472/comment/a8a498f3_b1d0e300 PS2, Line 142: .unwrap_or_else(|_| "<Unknown chip>".into()); I don't like this clippy lint; we really don't care about the cost of this allocation, and this is harder to read.