Attention is currently required from: Evan Benn.
3 comments:
File util/flashrom_tester/flashrom/src/cmd.rs:
Patch Set #2, Line 89: return
This can be converted to drop the `return` too?
File util/flashrom_tester/src/tests.rs:
Patch Set #2, Line 135: let mut filter_names: Option<HashSet<String>> = if let Some(names) = test_names {
I think this version is easier to understand, but if you prefer the newer version then go ahead.
Patch Set #2, Line 142: .unwrap_or_else(|_| "<Unknown chip>".into());
I don't like this clippy lint; we really don't care about the cost of this allocation, and this is harder to read.
To view, visit change 67472. To unsubscribe, or for help writing mail filters, visit settings.