Change in flashrom[master]: programmer_table: move each entry to the associated programmer source
Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52946 )
Change subject: programmer_table: move each entry to the associated programmer source ......................................................................
Patch Set 4: Code-Review+1
(26 comments)
File atahpt.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/d6f7ea79_32831634 PS4, Line 34: const struct dev_entry ata_hpt[] = { Can be `static` now?
File atapromise.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/bb1d2749_58cc47d7 PS4, Line 49: const struct dev_entry ata_promise[] = { Can be `static` now?
File atavia.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/5f0558a6_9d2849df PS4, Line 51: const struct dev_entry ata_via[] = { Can be `static` now?
File ch341a_spi.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/37ca1623_225334f6 PS4, Line 87: const struct dev_entry devs_ch341a_spi[] = { Can be `static` now?
File dediprog.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/00a2fdb4_edaa8c12 PS4, Line 155: const struct dev_entry devs_dediprog[] = { Can be `static` now?
File developerbox_spi.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/c59f802b_ad5e85e9 PS4, Line 58: const struct dev_entry devs_developerbox_spi[] = { Can be `static` now?
File digilent_spi.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/2babdd33_32295324 PS4, Line 56: const struct dev_entry devs_digilent_spi[] = { Can be `static` now?
File drkaiser.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/d56d5a19_a2852063 PS4, Line 32: const struct dev_entry drkaiser_pcidev[] = { Can be `static` now?
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/156855a3_36b65c7a PS4, Line 62: const struct dev_entry devs_ft2232spi[] = { Can be `static` now?
File gfxnvidia.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/9c8f720e_7a4d2a0b PS4, Line 33: const struct dev_entry gfx_nvidia[] = { Can be `static` now?
File it8212.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/05c371a9_9f55677a PS4, Line 26: const struct dev_entry devs_it8212[] = { Can be `static` now?
File nic3com.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/9068e9e1_ad8fdf32 PS4, Line 36: const struct dev_entry nics_3com[] = { Can be `static` now?
File nicintel.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/465b7b51_fd24431a PS4, Line 26: const struct dev_entry nics_intel[] = { Can be `static` now?
File nicintel_eeprom.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/1b7903a6_9588c4e0 PS4, Line 84: const struct dev_entry nics_intel_ee[] = { Can be `static` now?
File nicintel_spi.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/fa51cd7a_fff83e4c PS4, Line 80: const struct dev_entry nics_intel_spi[] = { Can be `static` now?
File nicnatsemi.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/592e1ec1_a9879ee7 PS4, Line 30: const struct dev_entry nics_natsemi[] = { Can be `static` now?
File nicrealtek.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/7bd6b984_8d116277 PS4, Line 30: const struct dev_entry nics_realtek[] = { Can be `static` now?
https://review.coreboot.org/c/flashrom/+/52946/comment/03f5c6bd_091a3791 PS4, Line 131: /* This programmer works for Realtek RTL8139 and SMC 1211. */ This comment seems very lost here. Maybe just drop it?
File ogp_spi.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/ca3e09ab_a6f5a14d PS4, Line 46: const struct dev_entry ogp_spi[] = { Can be `static` now?
File pickit2_spi.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/13991d1b_6ecb65ff PS4, Line 49: const struct dev_entry devs_pickit2_spi[] = { Can be `static` now?
File programmer.h:
https://review.coreboot.org/c/flashrom/+/52946/comment/64db74ed_e03d25f1 PS4, Line 402: #if CONFIG_DUMMY == 1 Please just drop all these `#if`. The only difference it makes is whether we get a compile-time or link-time error if something goes wrong. I don't think it matters or even justifies the clutter.
Mentioning the file name is also a bit redundant. Maybe just a single comment /* programmer drivers */ ?
Doesn't have to be in this patch, though.
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/103fcce1_5d18901a PS4, Line 352: const struct dev_entry devs_raiden[] = { Can be `static` now?
File satamv.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/558da6af_b134c41a PS4, Line 28: const struct dev_entry satas_mv[] = { Can be `static` now?
File satasii.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/0acd332d_9c74467e PS4, Line 29: const struct dev_entry satas_sii[] = { Can be `static` now?
File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/6f6bc7d5_44921ad0 PS4, Line 117: const struct dev_entry devs_stlinkv3_spi[] = { Can be `static` now?
File usbblaster_spi.c:
https://review.coreboot.org/c/flashrom/+/52946/comment/15b024ad_26cfc46e PS4, Line 48: const struct dev_entry devs_usbblasterspi[] = { Can be `static` now?
-
Nico Huber (Code Review)