Attention is currently required from: Thomas Heijligen.

Patch set 4:Code-Review +1

View Change

26 comments:

• File atahpt.c:

  • Patch Set #4, Line 34: const struct dev_entry ata_hpt[] = {

    Can be `static` now?

• File atapromise.c:

  • Patch Set #4, Line 49: const struct dev_entry ata_promise[] = {

    Can be `static` now?

• File atavia.c:

  • Patch Set #4, Line 51: const struct dev_entry ata_via[] = {

    Can be `static` now?

• File ch341a_spi.c:

  • Patch Set #4, Line 87: const struct dev_entry devs_ch341a_spi[] = {

    Can be `static` now?

• File dediprog.c:

  • Patch Set #4, Line 155: const struct dev_entry devs_dediprog[] = {

    Can be `static` now?

• File developerbox_spi.c:

  • Patch Set #4, Line 58: const struct dev_entry devs_developerbox_spi[] = {

    Can be `static` now?

• File digilent_spi.c:

  • Patch Set #4, Line 56: const struct dev_entry devs_digilent_spi[] = {

    Can be `static` now?

• File drkaiser.c:

  • Patch Set #4, Line 32: const struct dev_entry drkaiser_pcidev[] = {

    Can be `static` now?

• File ft2232_spi.c:

  • Patch Set #4, Line 62: const struct dev_entry devs_ft2232spi[] = {

    Can be `static` now?

• File gfxnvidia.c:

  • Patch Set #4, Line 33: const struct dev_entry gfx_nvidia[] = {

    Can be `static` now?

• File it8212.c:

  • Patch Set #4, Line 26: const struct dev_entry devs_it8212[] = {

    Can be `static` now?

• File nic3com.c:

  • Patch Set #4, Line 36: const struct dev_entry nics_3com[] = {

    Can be `static` now?

• File nicintel.c:

  • Patch Set #4, Line 26: const struct dev_entry nics_intel[] = {

    Can be `static` now?

• File nicintel_eeprom.c:

  • Patch Set #4, Line 84: const struct dev_entry nics_intel_ee[] = {

    Can be `static` now?

• File nicintel_spi.c:

  • Patch Set #4, Line 80: const struct dev_entry nics_intel_spi[] = {

    Can be `static` now?

• File nicnatsemi.c:

  • Patch Set #4, Line 30: const struct dev_entry nics_natsemi[] = {

    Can be `static` now?

• File nicrealtek.c:

  • Patch Set #4, Line 30: const struct dev_entry nics_realtek[] = {

    Can be `static` now?

  • Patch Set #4, Line 131: /* This programmer works for Realtek RTL8139 and SMC 1211. */

    This comment seems very lost here. Maybe just drop it?

• File ogp_spi.c:

  • Patch Set #4, Line 46: const struct dev_entry ogp_spi[] = {

    Can be `static` now?

• File pickit2_spi.c:

  • Patch Set #4, Line 49: const struct dev_entry devs_pickit2_spi[] = {

    Can be `static` now?

• File programmer.h:

  • Patch Set #4, Line 402: #if CONFIG_DUMMY == 1

    Please just drop all these `#if`. The only difference it makes is
    whether we get a compile-time or link-time error if something goes
    wrong. I don't think it matters or even justifies the clutter.

    Mentioning the file name is also a bit redundant. Maybe just a single
    comment /* programmer drivers */ ?

    Doesn't have to be in this patch, though.

• File raiden_debug_spi.c:

  • Patch Set #4, Line 352: const struct dev_entry devs_raiden[] = {

    Can be `static` now?

• File satamv.c:

  • Patch Set #4, Line 28: const struct dev_entry satas_mv[] = {

    Can be `static` now?

• File satasii.c:

  • Patch Set #4, Line 29: const struct dev_entry satas_sii[] = {

    Can be `static` now?

• File stlinkv3_spi.c:

  • Patch Set #4, Line 117: const struct dev_entry devs_stlinkv3_spi[] = {

    Can be `static` now?

• File usbblaster_spi.c:

  • Patch Set #4, Line 48: const struct dev_entry devs_usbblasterspi[] = {

    Can be `static` now?

To view, visit change 52946. To unsubscribe, or for help writing mail filters, visit settings.