Attention is currently required from: Peter Marheine. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51967 )
Change subject: lspcon_i2c_spi: support a devpath option ......................................................................
Patch Set 1:
(2 comments)
File lspcon_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/51967/comment/03d827eb_6153905c PS1, Line 436: /* TODO: remove this out of the specific SPI master implementation. */ Idea for another patch: Provide a `i2c_open_from_programmer_param` I2C helper function that returns a fd for an I2C device, using programmer params `devpath` and `bus`?
https://review.coreboot.org/c/flashrom/+/51967/comment/8e1130ba_c91c0abc PS1, Line 486: msg_perr("%s: one of devpath or bus must be specified\n", __func__); If both arguments are specified, `bus` is silently ignored. Should this case be treated as an error?