Change in flashrom[master]: lspcon_i2c_spi: support a devpath option

[Angel Pons (Code Review)]

Attention is currently required from: Peter Marheine.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51967 )

Change subject: lspcon_i2c_spi: support a devpath option
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

File i2c_helper_linux.c:

https://review.coreboot.org/c/flashrom/+/51967/comment/45504807_c0973a47 
PS1, Line 46: 		goto err;
`goto` isn't necessary here, just return `fd`.


https://review.coreboot.org/c/flashrom/+/51967/comment/41a9c15d_338637ac 
PS1, Line 54: 		goto err;
Same here, just return `err`.


https://review.coreboot.org/c/flashrom/+/51967/comment/a23a2a96_c0d8332c 
PS1, Line 58: 	return ret ? ret : fd;
And return `fd` here.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/51967
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id2adf8a307b9205ce5e5804a6c3e22f19d0c34c9
Gerrit-Change-Number: 51967
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Marheine <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Peter Marheine <[e-mail]>
Gerrit-Comment-Date: Wed, 31 Mar 2021 09:04:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment