[M] Change in flashrom[master]: Documentation: Add build instructions for meson - flashrom-gerrit

6 Sep 2022


      Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66862 )
Change subject: Documentation: Add build instructions for meson
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File Documentation/building.md:
https://review.coreboot.org/c/flashrom/+/66862/comment/59c715d2_eaaac030 
PS5, Line 31: meson build -D<your_options>
I was confused at first, because meson has `configure` command, which is not the same as build, and can be used to re-configure existing build directory.
...
meson configure -D<your_options>
If you meant `build` here as a build directory and not a command, let's maybe call it `builddir` (here and below) ?
https://review.coreboot.org/c/flashrom/+/66862/comment/efc6127b_777e50fd 
PS5, Line 47: tests
Should this be `test` (not `tests`) ? I always run `ninja test` command.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/66862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3476f17fa274cd71e3e0e84f791d547d08165ecb
Gerrit-Change-Number: 66862
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Tue, 06 Sep 2022 22:53:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment