Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan.

Patch set 5:Code-Review +1

View Change

2 comments:

• File Documentation/building.md:

  • Patch Set #5, Line 31: meson build -D<your_options>

    I was confused at first, because meson has `configure` command, which is not the same as build, and can be used to re-configure existing build directory.
    > meson configure -D<your_options>

    If you meant `build` here as a build directory and not a command, let's maybe call it `builddir` (here and below) ?

  • Patch Set #5, Line 47: tests

    Should this be `test` (not `tests`) ? I always run `ninja test` command.

To view, visit change 66862. To unsubscribe, or for help writing mail filters, visit settings.