Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons.
Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49255 )
Change subject: bitbang-spi.c: support clock polarity and phase
......................................................................
Patch Set 26:
(3 comments)
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/49255/comment/6b95b21f_b363f031
PS12, Line 208:
: if (parse_spi_mode(&cpol, &cpha))
: return ERROR_FLASHROM_BUG;
No you should initialise to 0 explicitly, not rely on the specific toolchain that happens to be inst […]
Ok. Initialization code has been added.
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/49255/comment/9d60aed7_17c60aef
PS14, Line 41:
: static int cpol; /* Clock Polarity */
: static int cpha; /* Clock Phase */
not done.
Done
https://review.coreboot.org/c/flashrom/+/49255/comment/0ae6938c_46f88abb
PS14, Line 210: ERROR_FLASHROM_BUG
not done, please don't resolve if not actually resolved. […]
Thank you very much
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49255
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I04c1dfe132d756119229b27c3cd611d1be1abc8d
Gerrit-Change-Number: 49255
Gerrit-PatchSet: 26
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 18 Jan 2021 03:12:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xiang Wang
merle@hardenedlinux.org
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment