Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons.

View Change

3 comments:

• File bitbang_spi.c:

  • Patch Set #12, Line 208:

    
    	if (parse_spi_mode(&cpol, &cpha))
    		return ERROR_FLASHROM_BUG;
    

    No you should initialise to 0 explicitly, not rely on the specific toolchain that happens to be inst […]

    Ok. Initialization code has been added.

• File bitbang_spi.c:

  • Patch Set #14, Line 41:

    
    static int cpol; /* Clock Polarity */
    static int cpha; /* Clock Phase */
    

    not done.

    Done

  • Patch Set #14, Line 210: ERROR_FLASHROM_BUG

    not done, please don't resolve if not actually resolved. […]

    Thank you very much

To view, visit change 49255. To unsubscribe, or for help writing mail filters, visit settings.