Attention is currently required from: Nico Huber, Namyoon Woo, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 )
Change subject: dummyflasher.c: Extract params processing into a separate function ......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS3: Rebased on the top of all latest improvements and fixes.
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54748/comment/5c7a8a8b_6e4db04e PS1, Line 26: /* Remove the #define below if you don't want SPI flash chip emulation. */ : #define EMULATE_SPI_CHIP 1
If this line is removed, dummy does not compile. […]
This comment still valid, I think.
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54748/comment/962737ad_d17c4b46 PS2, Line 975: return 1;
This will result in `data->flashchip_contents` leaking. […]
I replied below
https://review.coreboot.org/c/flashrom/+/54748/comment/c34221e2_d1f975c6 PS2, Line 1014:
I moved around the initialisation in CB:54908
I moved initialisation in the same way (rebased), but I had a choice where to put it: init_data vs dummy_init. To me it looks like it can be in init_data? (because it inits data). And all the memory leaks seems to be fixed by now...