Attention is currently required from: Anastasia Klimchuk, Patrick Georgi.
Peter Marheine has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/86350?usp=email )
Change subject: doc: autogenerate a list of authors and hall of fame ......................................................................
Patch Set 12:
(5 comments)
Patchset:
PS11:
This is going great! I am so so so happy 😊 […]
Done
File doc/about_flashrom/hall_of_fame.rst:
https://review.coreboot.org/c/flashrom/+/86350/comment/937eab22_31c6c9c8?usp... : PS11, Line 9: code reviewers
maybe let's just say "reviewers" ? one word for each section
Done
https://review.coreboot.org/c/flashrom/+/86350/comment/1e9d7715_485934f1?usp... : PS11, Line 21: =======
I am curious, this is 7 chars, and in the same situation on the Contact page we had to add one more […]
It seems to notice if I have that in a diff, but seems fine to have that in a commit. If I `git reset --mixed` to the parent then `git diff --check`, it sees that as a conflict marker.
Since there's no issue in actually including that in a commit, it seems fine.
File doc/about_flashrom/index.rst:
https://review.coreboot.org/c/flashrom/+/86350/comment/bae13166_42b63286?usp... : PS11, Line 10: hall_of_fame
I would put it #2 in the list, after Team […]
Done
File doc/collect-authors.sh:
https://review.coreboot.org/c/flashrom/+/86350/comment/aff71eef_dc73e173?usp... : PS11, Line 11: Co-Authored-by
Can we also add `Co-developed-by` ? in addition to `Co-Authored-by` […]
Sure; `Co-developed-by` has 14 items, whereas `Co-authored-by` has 8.
-
Peter Marheine (Code Review)