Attention is currently required from: Anastasia Klimchuk, Patrick Georgi.
5 comments:
Patchset:
This is going great! I am so so so happy 😊 […]
Done
File doc/about_flashrom/hall_of_fame.rst:
Patch Set #11, Line 9: code reviewers
maybe let's just say "reviewers" ? one word for each section
Done
Patch Set #11, Line 21: =======
I am curious, this is 7 chars, and in the same situation on the Contact page we had to add one more […]
It seems to notice if I have that in a diff, but seems fine to have that in a commit. If I `git reset --mixed` to the parent then `git diff --check`, it sees that as a conflict marker.
Since there's no issue in actually including that in a commit, it seems fine.
File doc/about_flashrom/index.rst:
Patch Set #11, Line 10: hall_of_fame
I would put it #2 in the list, after Team […]
Done
File doc/collect-authors.sh:
Patch Set #11, Line 11: Co-Authored-by
Can we also add `Co-developed-by` ? in addition to `Co-Authored-by` […]
Sure; `Co-developed-by` has 14 items, whereas `Co-authored-by` has 8.
To view, visit change 86350. To unsubscribe, or for help writing mail filters, visit settings.