Change in ...flashrom[master]: serprog.c: Remove unneeded 'else'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33348

Change subject: serprog.c: Remove unneeded 'else'
......................................................................

serprog.c: Remove unneeded 'else'

'else' is not needed after a 'break' or 'return'.

Change-Id: I9015020889c25ecbd391a18f56f99affc8ea307d
Signed-off-by: Elyes HAOUAS 
---
M serprog.c
1 file changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/33348/1

diff --git a/serprog.c b/serprog.c
index c3d48a4..b7ef35c 100644
--- a/serprog.c
+++ b/serprog.c
@@ -937,9 +937,8 @@
     * needed for non-SPI chips). Below we make sure that the requested range is within this window. */
    if ((phys_addr & 0xFF000000) == 0xFF000000) {
    	return (void*)phys_addr;
-	} else {
-		msg_pwarn(MSGHEADER "requested mapping %s is incompatible: 0x%zx bytes at 0x%0*" PRIxPTR ".\n",
-			  descr, len, PRIxPTR_WIDTH, phys_addr);
-		return NULL;
    }
+	msg_pwarn(MSGHEADER "requested mapping %s is incompatible: 0x%zx bytes at 0x%0*" PRIxPTR ".\n",
+		  descr, len, PRIxPTR_WIDTH, phys_addr);
+	return NULL;
 }

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33348 )

Change subject: serprog.c: Remove unneeded 'else'
......................................................................

Patch Set 1: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33348 )

Change subject: serprog.c: Remove unneeded 'else'
......................................................................

serprog.c: Remove unneeded 'else'

'else' is not needed after a 'break' or 'return'.

Change-Id: I9015020889c25ecbd391a18f56f99affc8ea307d
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/33348
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M serprog.c
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/serprog.c b/serprog.c
index c3d48a4..b7ef35c 100644
--- a/serprog.c
+++ b/serprog.c
@@ -937,9 +937,8 @@
     * needed for non-SPI chips). Below we make sure that the requested range is within this window. */
    if ((phys_addr & 0xFF000000) == 0xFF000000) {
    	return (void*)phys_addr;
-	} else {
-		msg_pwarn(MSGHEADER "requested mapping %s is incompatible: 0x%zx bytes at 0x%0*" PRIxPTR ".\n",
-			  descr, len, PRIxPTR_WIDTH, phys_addr);
-		return NULL;
    }
+	msg_pwarn(MSGHEADER "requested mapping %s is incompatible: 0x%zx bytes at 0x%0*" PRIxPTR ".\n",
+		  descr, len, PRIxPTR_WIDTH, phys_addr);
+	return NULL;
 }