Nico Huber merged this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
serprog.c: Remove unneeded 'else'

'else' is not needed after a 'break' or 'return'.

Change-Id: I9015020889c25ecbd391a18f56f99affc8ea307d
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/33348
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M serprog.c
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/serprog.c b/serprog.c
index c3d48a4..b7ef35c 100644
--- a/serprog.c
+++ b/serprog.c
@@ -937,9 +937,8 @@
* needed for non-SPI chips). Below we make sure that the requested range is within this window. */
if ((phys_addr & 0xFF000000) == 0xFF000000) {
return (void*)phys_addr;
- } else {
- msg_pwarn(MSGHEADER "requested mapping %s is incompatible: 0x%zx bytes at 0x%0*" PRIxPTR ".\n",
- descr, len, PRIxPTR_WIDTH, phys_addr);
- return NULL;
}
+ msg_pwarn(MSGHEADER "requested mapping %s is incompatible: 0x%zx bytes at 0x%0*" PRIxPTR ".\n",
+ descr, len, PRIxPTR_WIDTH, phys_addr);
+ return NULL;
}

To view, visit change 33348. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9015020889c25ecbd391a18f56f99affc8ea307d
Gerrit-Change-Number: 33348
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged