Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66684 )
Change subject: flashrom.c: create is_internal_programmer() helper ......................................................................
Patch Set 9: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66684/comment/f7f14464_9027bf72 PS9, Line 9: This has the added benefit of cutting down one some : pre-processor usage as suggested by Angel Pons as the : function is always defined. I find this a bit confusing. Suggestion:
As suggested by Angel Pons, add the function `is_internal_programmer` and cut down some pre-processor usage by moving them into that new function. <empty> The function checks if the internal programmer is the selected one. If the internal programmer is not built in, then it returns just false.