Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.

Patch set 9:Code-Review +2

View Change

1 comment:

• Commit Message:

  • Patch Set #9, Line 9:

    This has the added benefit of cutting down one some
    pre-processor usage as suggested by Angel Pons as the
    function is always defined.
    

    I find this a bit confusing. Suggestion:

      As suggested by Angel Pons, add the function `is_internal_programmer`
      and cut down some pre-processor usage by moving them into that new
      function.
      <empty>
      The function checks if the internal programmer is the
      selected one. If the internal programmer is not built in, then it
      returns just false.

To view, visit change 66684. To unsubscribe, or for help writing mail filters, visit settings.