Attention is currently required from: Aarya, Anastasia Klimchuk, Hsuan-ting Chen, Nikolai Artemiev.
Peter Marheine has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/82496?usp=email )
Change subject: Correct get_flash_region() to use inclusive upper bounds
......................................................................
Patch Set 6:
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/82496/comment/28a45641_d25f224b?usp... :
PS6, Line 2240: start = region->end + 1;
Just want to double-check: This and all other layout-related occurrences in `layout. […]
I think that's right. I only identified `get_flash_region` as a problem, and that was added along with all the code that uses it at about the same time.
File include/layout.h:
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82496?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ia0ca867aef33b598c2697fc264807fa5e29683ec
Gerrit-Change-Number: 82496
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Tue, 28 May 2024 02:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com