Attention is currently required from: Aarya, Anastasia Klimchuk, Hsuan-ting Chen, Nikolai Artemiev.
View Change
2 comments:
File flashrom.c:
Patch Set #6, Line 2240: start = region->end + 1;
Just want to double-check: This and all other layout-related occurrences in `layout. […]
I think that's right. I only identified `get_flash_region` as a problem, and that was added along with all the code that uses it at about the same time.
File include/layout.h:
To view, visit change 82496. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ia0ca867aef33b598c2697fc264807fa5e29683ec
Gerrit-Change-Number: 82496
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Tue, 28 May 2024 02:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <roccochen@google.com>