Attention is currently required from: Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55106 )
Change subject: nic3com.c: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 1:
(2 comments)
File nic3com.c:
https://review.coreboot.org/c/flashrom/+/55106/comment/d74a640c_32cfbd83 PS1, Line 144: msg_perr("Unable to allocate space for PAR master data\n"); Shouldn't we do what nic3com_shutdown() does, here? (or call it with a locally declared struct nic3com_data instead of the three individual variables)
https://review.coreboot.org/c/flashrom/+/55106/comment/c65ac3f6_44464d8e PS1, Line 152: free(data); Same here? (although this path was already wrong before)