Attention is currently required from: Angel Pons, Anastasia Klimchuk.
View Change
2 comments:
File nic3com.c:
Patch Set #1, Line 144: msg_perr("Unable to allocate space for PAR master data\n");
Shouldn't we do what nic3com_shutdown() does, here? (or call it
with a locally declared struct nic3com_data instead of the three
individual variables)
Patch Set #1, Line 152: free(data);
Same here? (although this path was already wrong before)
To view, visit change 55106. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c3e4836760cc9f4f9a0bd4294e8d2407b150566
Gerrit-Change-Number: 55106
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Sat, 05 Jun 2021 16:49:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment