Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59183 )
Change subject: libflashrom,writeprotect: add flashrom_wp_get_range() ......................................................................
Patch Set 2:
(3 comments)
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/59183/comment/89ada889_6d4b9fbf PS2, Line 141: int flashrom_wp_get_range(const struct flashrom_wp_chip_config *cfg, struct flashrom_wp_range *range); You can omit param names here, and the same for the rest of the chain (since the rest of the chain is adding functions in this header)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/59183/comment/d8c94078_beba47aa PS2, Line 182: cfg->chip Unless people convince me otherwise, I think chip can be an argument to flashrom_wp_get_range , and no need to store a pointer in wp_chip_config.
https://review.coreboot.org/c/flashrom/+/59183/comment/cc96580a_8fdc0160 PS2, Line 183: decode_range Yes, you can pass chip_len as one more argument, doesn't need to be in range struct.
-
Anastasia Klimchuk (Code Review)