Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk.

View Change

3 comments:

• File libflashrom.h:

  • Patch Set #2, Line 141: int flashrom_wp_get_range(const struct flashrom_wp_chip_config *cfg, struct flashrom_wp_range *range);

    You can omit param names here, and the same for the rest of the chain (since the rest of the chain is adding functions in this header)

• File writeprotect.c:

  • Patch Set #2, Line 182: cfg->chip

    Unless people convince me otherwise, I think chip can be an argument to flashrom_wp_get_range , and no need to store a pointer in wp_chip_config.

  • Patch Set #2, Line 183: decode_range

    Yes, you can pass chip_len as one more argument, doesn't need to be in range struct.

To view, visit change 59183. To unsubscribe, or for help writing mail filters, visit settings.