Attention is currently required from: Felix Singer, Thomas Heijligen, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67664 )
Change subject: tests: add basic lifecycle test for ch341a_spi ......................................................................
Patch Set 8:
(1 comment)
File tests/ch341a_spi.c:
https://review.coreboot.org/c/flashrom/+/67664/comment/0aee38dd_335adbb8 PS8, Line 38: if (transfer->endpoint == WRITE_EP) Just wanted to mention: the assertion on the previous line makes sure this condition is always true. Technically this "if" is not needed in this patch. However, I see that it becomes needed in the next patch. My preference would be to introduce this "if" condition in the next patch, so that it would be very clear why the code is there. But if other people have strong opposite opinions, I can live with "if" in this patch.
-
Anastasia Klimchuk (Code Review)