Attention is currently required from: Felix Singer, Thomas Heijligen, Alexander Goncharov.

View Change

1 comment:

• File tests/ch341a_spi.c:

  • Patch Set #8, Line 38: if (transfer->endpoint == WRITE_EP)

    Just wanted to mention: the assertion on the previous line makes sure this condition is always true. Technically this "if" is not needed in this patch. However, I see that it becomes needed in the next patch.
    My preference would be to introduce this "if" condition in the next patch, so that it would be very clear why the code is there.
    But if other people have strong opposite opinions, I can live with "if" in this patch.

To view, visit change 67664. To unsubscribe, or for help writing mail filters, visit settings.