Nico Huber has posted comments on this change. ( https://review.coreboot.org/19206 )
Change subject: Convert flashrom to git ......................................................................
Patch Set 7:
(3 comments)
So close, but the missing `fi`... Also, it looks like your comments about made changes are not in sync with the current patch set (see inline `?`).
https://review.coreboot.org/#/c/19206/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/19206/6//COMMIT_MSG@15 PS6, Line 15: The latter is added with this change.
Done
?
https://review.coreboot.org/#/c/19206/6/util/getrevision.sh File util/getrevision.sh:
https://review.coreboot.org/#/c/19206/6/util/getrevision.sh@140 PS6, Line 140: return ${EXIT_FAILURE} : fi : : echo "${r}" : } : : is_t
Done. I also took the liberty of reducing the indent level of this function
?
https://review.coreboot.org/#/c/19206/6/util/git-hooks/pre-push File util/git-hooks/pre-push:
https://review.coreboot.org/#/c/19206/6/util/git-hooks/pre-push@48 PS6, Line 48: commit=$(git rev-list -n 1 --all-match --invert-grep -E \ `fi` lost?