Nico Huber posted comments on this change.

View Change

Patch set 7:

So close, but the missing `fi`... Also, it looks like your comments
about made changes are not in sync with the current patch set (see
inline `?`).

(3 comments)

• Commit Message:

  • Patch Set #6, Line 15: The latter is added with this change.

    Done

    ?

• File util/getrevision.sh:

  • Patch Set #6, Line 140:

    		return ${EXIT_FAILURE}
    	fi
    
    	echo "${r}"
    }
    
    is_t
    

    Done. I also took the liberty of reducing the indent level of this function

    ?

• File util/git-hooks/pre-push:

  • Patch Set #6, Line 48: commit=$(git rev-list -n 1 --all-match --invert-grep -E \

    `fi` lost?

To view, visit change 19206. To unsubscribe, visit settings.