Change in flashrom[master]: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Alan Green, Simon Buhrow, Nico Huber, Samir Ibradžić.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )

Change subject: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call
......................................................................

Patch Set 25:

(1 comment)

File ft2232_spi.c:

https://review.coreboot.org/c/flashrom/+/40477/comment/6d22a01e_86bdefc1 
PS25, Line 189: ft2232_spi_send_command
> There's much repeated code between send_command and send_multicommand. […]

Regarding this idea.

Probably a suitable intermediate change would be to factor common logic out into a internal static function ft2232_spi_send_command_common() that backs both the concrete callback implementations. Such a refactor definitely seems to be a patch with scope to support its own merits.

If it is indeed reasonable for the two callback wrappers to be folded up into common then so be it but the common factorisation and fold step seem to be distinct to me.