Attention is currently required from: Alan Green, Simon Buhrow, Nico Huber, Samir Ibradžić.

View Change

1 comment:

• File ft2232_spi.c:

  • Patch Set #25, Line 189: ft2232_spi_send_command

    There's much repeated code between send_command and send_multicommand. […]

    Regarding this idea.

    Probably a suitable intermediate change would be to factor common logic out into a internal static function ft2232_spi_send_command_common() that backs both the concrete callback implementations. Such a refactor definitely seems to be a patch with scope to support its own merits.

    If it is indeed reasonable for the two callback wrappers to be folded up into common then so be it but the common factorisation and fold step seem to be distinct to me.

To view, visit change 40477. To unsubscribe, or for help writing mail filters, visit settings.