Change in flashrom[master]: Add support for National Instruments USB-845x devices

[Márton Miklós (Code Review)]

Márton Miklós has posted comments on this change. ( https://review.coreboot.org/25683 )

Change subject: Add support for National Instruments USB-845x devices
......................................................................


Patch Set 8:

(3 comments)

https://review.coreboot.org/#/c/25683/3/flashrom.c
File flashrom.c:

https://review.coreboot.org/#/c/25683/3/flashrom.c@417
PS3, Line 417: 	{
             : 		.name			= "digilent_spi",
             : 		.type			= USB,
             : 		.devs.dev		= devs_digilent_spi,
             : 		.init			= digilent_spi_init,
             : 		.map_flash_region	= fallback_map,
             : 		.unmap_flash_region	= fallback_unmap,
             : 		.delay			= internal_delay,
             : 	},
> Please use tabs for indentation
> Done

https://review.coreboot.org/#/c/25683/8/ni845x_spi.c
File ni845x_spi.c:

PS8:
> I'm only through half the file yet, will have to continue another time... hopefully soon.
> Thanks for the review I will fix the comments soon!

https://review.coreboot.org/#/c/25683/8/ni845x_spi.c@63
PS8, Line 63: /* Copied from dediprog.c */
> If it's really a verbatim copy, please place it into its own file […]
> Actually it is copied from the pickit2 code:
> https://github.com/flashrom/flashrom/blob/master/pickit2_spi.c#L302

I am under the impression too that these spi clock speed calculation functions shall be uniformized & placed to a common place. What do you recommend? Should I create an another patchset which modifies dediprog, pickit and rebase this onto the top of that?



-- 
To view, visit https://review.coreboot.org/25683
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549
Gerrit-Change-Number: 25683
Gerrit-PatchSet: 8
Gerrit-Owner: David Hendricks <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Miklós Márton <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Elyes HAOUAS <[e-mail]>
Gerrit-CC: Márton Miklós <[e-mail]>
Gerrit-Comment-Date: Sun, 19 Aug 2018 13:54:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No