View Change

3 comments:

• File flashrom.c:

  • Patch Set #3, Line 417:

    	{
    		.name			= "digilent_spi",
    		.type			= USB,
    		.devs.dev		= devs_digilent_spi,
    		.init			= digilent_spi_init,
    		.map_flash_region	= fallback_map,
    		.unmap_flash_region	= fallback_unmap,
    		.delay			= internal_delay,
    	},
    

    Please use tabs for indentation

    Done

• File ni845x_spi.c:

  • Patch Set #8:

    I'm only through half the file yet, will have to continue another time... hopefully soon.

    Thanks for the review I will fix the comments soon!

  • Patch Set #8, Line 63: /* Copied from dediprog.c */

    If it's really a verbatim copy, please place it into its own file […]

    Actually it is copied from the pickit2 code:
    https://github.com/flashrom/flashrom/blob/master/pickit2_spi.c#L302

    I am under the impression too that these spi clock speed calculation functions shall be uniformized & placed to a common place. What do you recommend? Should I create an another patchset which modifies dediprog, pickit and rebase this onto the top of that?

To view, visit change 25683. To unsubscribe, or for help writing mail filters, visit settings.