[L] Change in flashrom[master]: cli_classic: include a fallback inplementation of getopt

[Thomas Heijligen (Code Review)]

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73102 )

Change subject: cli_classic: include a fallback inplementation of getopt
......................................................................

Patch Set 10:

(5 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/73102/comment/e57f1cbc_9a03e13b 
PS7, Line 12: DJGPP/DOS
> I think inline is better: […]

Done

File cli_getopt.c:

https://review.coreboot.org/c/flashrom/+/73102/comment/daf18dbc_a2b70a1a 
PS7, Line 254: 
             : 
             :
> Let's keep 1 line in between functions (in this file, some has 2-3 empty lines break)

Done

File include/cli_classic.h:

https://review.coreboot.org/c/flashrom/+/73102/comment/cfe24afc_e7e34674 
PS7, Line 1: #
> We need to add a license header? we still have them...

Done

https://review.coreboot.org/c/flashrom/+/73102/comment/8fc23f3b_f5133188 
PS7, Line 3:
> 1 line break is enough I think

Done

File meson.build:

https://review.coreboot.org/c/flashrom/+/73102/comment/beb38e6f_9e1dd2a6 
PS7, Line 637: cli_srcs = files(
             :   'cli_classic.c',
             :   'cli_common.c',
             :   'cli_output.c'
             : )
             : 
             : if not cc.has_function('getopt_long')
             :   cli_srcs += files('cli_getopt.c')
             : endif
             : 
             :
> This block should be intended to the right it seems? it is inside if condition?

Done