Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

5 comments:

• Commit Message:

  • Patch Set #7, Line 12: DJGPP/DOS

    I think inline is better: […]

    Done

• File cli_getopt.c:

  • Patch Set #7, Line 254:

    Let's keep 1 line in between functions (in this file, some has 2-3 empty lines break)

    Done

• File include/cli_classic.h:

  • Patch Set #7, Line 1: #

    We need to add a license header? we still have them...

    Done

  • Patch Set #7, Line 3:

    1 line break is enough I think

    Done

• File meson.build:

  • Patch Set #7, Line 637:

    cli_srcs = files(
      'cli_classic.c',
      'cli_common.c',
      'cli_output.c'
    )
    
    if not cc.has_function('getopt_long')
      cli_srcs += files('cli_getopt.c')
    endif
    
    
    

    This block should be intended to the right it seems? it is inside if condition?

    Done

To view, visit change 73102. To unsubscribe, or for help writing mail filters, visit settings.