Attention is currently required from: Felix Singer, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68068 )
Change subject: [WIP] test_build.sh: Rework programmer selection using Meson ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Is that file not in a standard format? I wouldn't know, is it python?
It's not python or at least it doesn't like the colons. Not my best hack job, not my worst either: ``` def option(name, type, value = '', choices = [], description = ''): if name == 'programmer': for choice in choices: print(choice)
exec(open('meson_options.txt').read().replace(':', '=')) ```
This would break as soon as we'd have a colon in any programmer option. Not sure if that matters? Python's tokenizer seems to work in any case, maybe it would be possible to make the replacement after tokenization.