Attention is currently required from: Felix Singer, Angel Pons.
View Change
1 comment:
Patchset:
Patch Set #3:
Is that file not in a standard format? I wouldn't know, is it python?
It's not python or at least it doesn't like the colons. Not my best
hack job, not my worst either:
```
def option(name, type, value = '', choices = [], description = ''):
if name == 'programmer':
for choice in choices:
print(choice)
exec(open('meson_options.txt').read().replace(':', '='))
```
This would break as soon as we'd have a colon in any programmer option.
Not sure if that matters? Python's tokenizer seems to work in any case,
maybe it would be possible to make the replacement after tokenization.
To view, visit change 68068. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9f41ce2ff219c70c3c05a90134291b01a084c859
Gerrit-Change-Number: 68068
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 10:06:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment