Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48879 )
Change subject: sb600spi.c: add rev 0x51 to the leading comment block ......................................................................
sb600spi.c: add rev 0x51 to the leading comment block
Signed-off-by: Idwer Vollering vidwer@gmail.com Change-Id: Ic74cff04f2d1fd92ad92aa37f71e5852f02d86a6 --- M sb600spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/48879/1
diff --git a/sb600spi.c b/sb600spi.c index ef9da4b..b9560e2 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -127,7 +127,7 @@ * found on both Stoney Ridge and Zen platforms. * * The revisions I have found by searching various lspci - * outputs are as follows: 0x4b, 0x59 & 0x61. + * outputs are as follows: 0x4b, 0x51, 0x59 & 0x61. */ } else if (rev == 0x4b || rev == 0x51 || rev == 0x59 || rev == 0x61) { msg_pdbg("Promontory (rev 0x%02x) detected.\n", rev);
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/48879
to look at the new patch set (#2).
Change subject: sb600spi.c: add rev 0x51 to the leading comment block ......................................................................
sb600spi.c: add rev 0x51 to the leading comment block
Signed-off-by: Idwer Vollering vidwer@gmail.com Change-Id: Ic74cff04f2d1fd92ad92aa37f71e5852f02d86a6 --- M sb600spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/48879/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48879 )
Change subject: sb600spi.c: add rev 0x51 to the leading comment block ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/48879/2/sb600spi.c File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/48879/2/sb600spi.c@130 PS2, Line 130: * outputs are as follows: 0x4b, 0x51, 0x59 & 0x61. Was 0x51 found by searching lspci outputs, though?
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48879 )
Change subject: sb600spi.c: add rev 0x51 to the leading comment block ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/48879/2/sb600spi.c File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/48879/2/sb600spi.c@130 PS2, Line 130: * outputs are as follows: 0x4b, 0x51, 0x59 & 0x61.
Was 0x51 found by searching lspci outputs, though?
Not sure. This change was intented to link to https://review.coreboot.org/c/flashrom/+/48779
Attention is currently required from: Idwer Vollering. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48879 )
Change subject: sb600spi.c: add rev 0x51 to the leading comment block ......................................................................
Patch Set 2:
(1 comment)
File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/48879/comment/66a85805_6423e36e PS2, Line 130: * outputs are as follows: 0x4b, 0x51, 0x59 & 0x61.
Not sure. This change was intented to link to https://review.coreboot. […]
I'd drop the whole sentence from the comment.
-
Angel Pons (Code Review) -
Idwer Vollering (Code Review)