Attention is currently required from: Edward O'Callaghan, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51706 )
Change subject: dediprog.c: Split up compound conditional statement ......................................................................
Patch Set 1:
(1 comment)
File dediprog.c:
https://review.coreboot.org/c/flashrom/+/51706/comment/64012864_48848732 PS1, Line 1276: if (register_spi_master(&spi_master_dediprog)) : return 1; : : return dediprog_set_leds(LED_NONE);
I've preserved the original behaviour of the code, just moved the `dediprog_set_leds` call out of th […]
Probably not worth to merge this as is if we are going to change the behavior anyway.
The order seems to have grown into this state before there were return values to check. And then somebody decided to check them. Switching the statements shouldn't make a difference for the hardware (register_spi_master() just performs software-internal setup). So I'm in favor to switch the two.