Attention is currently required from: Edward O'Callaghan, Angel Pons.

View Change

1 comment:

• File dediprog.c:

  • Patch Set #1, Line 1276:

    	if (register_spi_master(&spi_master_dediprog))
    		return 1;
    
    	return dediprog_set_leds(LED_NONE);
    

    I've preserved the original behaviour of the code, just moved the `dediprog_set_leds` call out of th […]

    Probably not worth to merge this as is if we are going
    to change the behavior anyway.

    The order seems to have grown into this state before there
    were return values to check. And then somebody decided
    to check them. Switching the statements shouldn't make
    a difference for the hardware (register_spi_master() just
    performs software-internal setup). So I'm in favor to
    switch the two.

To view, visit change 51706. To unsubscribe, or for help writing mail filters, visit settings.