Change in flashrom[master]: programmer_table: move each entry to the associated programmer source - flashrom-gerrit

8 Jun 2021


      Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52946 )
Change subject: programmer_table: move each entry to the associated programmer source
......................................................................
Patch Set 7:
(1 comment)
File programmer.h:
https://review.coreboot.org/c/flashrom/+/52946/comment/b6d6eae9_9e7a339e 
PS4, Line 402: #if CONFIG_DUMMY == 1
...
I am trying to understand, why it has to be an error (compile-time or link-time)? If some CONFIG_xxx […]
What I meant is that for sound code, it makes no difference. Only if there is an error
like trying to use `programmer_internal` with `CONFIG_INTERNAL=no`. With the #if, it
would be a compiler error (undeclared). Without the #if, it would be a linker error
(undefined).
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52946
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921
Gerrit-Change-Number: 52946
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Xiang W wxjstz@126.com
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Tue, 08 Jun 2021 14:46:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment