Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.

View Change

1 comment:

• File programmer.h:

  • Patch Set #4, Line 402: #if CONFIG_DUMMY == 1

    I am trying to understand, why it has to be an error (compile-time or link-time)? If some CONFIG_xxx […]

    What I meant is that for sound code, it makes no difference. Only if there is an error
    like trying to use `programmer_internal` with `CONFIG_INTERNAL=no`. With the #if, it
    would be a compiler error (undeclared). Without the #if, it would be a linker error
    (undefined).

To view, visit change 52946. To unsubscribe, or for help writing mail filters, visit settings.