Change in flashrom[master]: Makefile: enable internal programmer for x86 and all linux platforms
Attention is currently required from: Thomas Heijligen, Peter Marheine. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 )
Change subject: Makefile: enable internal programmer for x86 and all linux platforms ......................................................................
Patch Set 6: Code-Review+1
(4 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/f43d50a9_c029a9f0 PS3, Line 104: CONFIG_INTERNAL_MIPSLE \
I haven't looked it up yet
Done
https://review.coreboot.org/c/flashrom/+/61300/comment/3ab695b0_a0767769 PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
(mark_unsupported) works fine, it's just hard to understand what it does. […]
Done, I think.
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/e4273ade_6be73120 PS5, Line 594: CONFIG_INTERNAL_X86 := yes
The new patchset should fix all this. […]
A bit more redundancy, but also more explicit, looks ok.
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/5cd8f3a7_46d1ae8b PS6, Line 315: #ifneq ($(ARCH)-$(TARGET_OS), $(filter $(ARCH)-$(TARGET_OS), x86-$(TARGET_OS) $(ARCH)-Linux)) leftover?
-
Nico Huber (Code Review)