Attention is currently required from: Thomas Heijligen, Peter Marheine.

Patch set 6:Code-Review +1

View Change

4 comments:

• File Makefile:

  • Patch Set #3, Line 104: CONFIG_INTERNAL_MIPSLE \

    I haven't looked it up yet

    Done

  • Patch Set #3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)

    > (mark_unsupported) works fine, it's just hard to understand what it does. […]

    Done, I think.

• File Makefile:

  • Patch Set #5, Line 594: CONFIG_INTERNAL_X86 := yes

    The new patchset should fix all this. […]

    A bit more redundancy, but also more explicit, looks ok.

• File Makefile:

  • Patch Set #6, Line 315: #ifneq ($(ARCH)-$(TARGET_OS), $(filter $(ARCH)-$(TARGET_OS), x86-$(TARGET_OS) $(ARCH)-Linux))

    leftover?

To view, visit change 61300. To unsubscribe, or for help writing mail filters, visit settings.