Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email )
Change subject: libflashrom: Update the API for progress callback ......................................................................
Patch Set 8:
(3 comments)
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/86031/comment/cfb97eca_910e3b47?usp... : PS7, Line 112: */
The comment should probably have a note saying that this has priority over `flashrom_set_progress_ca […]
Done
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86031/comment/984ecd1a_74d3d268?usp... : PS7, Line 76: " ignoring this call since %s is deprecated\n",
nit: there is already a space on the previous line
Done
https://review.coreboot.org/c/flashrom/+/86031/comment/b589c1f6_4f0a52dc?usp... : PS7, Line 134: sizeof(flashctx->progress_state.user_data));
nit: Why use `memcpy()`? Types match, so simple assignments should do and will break if types chang […]
user_data was complaining on dereferencing void pointer so I changed to `memcpy()` and then I changed progress_state copying to memcpy so that they look the same.
For progress_state it wasn't needed, I changed it back to be an assignment.